How can I delete a file served by a custom controller after it has been downloaded?

Giuseppe

11/22/22, 5:47 PM

Starting from How do I create a file download URL? I've build a custom controller that allows users to download a PDF file.

my_module.routing.yml

my_module.pdf_link:
  path: '/my-module/pdf/download'
  defaults:
    _title: 'PDF download'
    _controller: '\Drupal\my_module\Controller\MyModuleController::downloadPDF'
  requirements:
    _role: 'authenticated'

MyModuleController

public function downloadPDF() {
  $pdf_stream = $this->restCallThatReturnAPdfStream();

  $headers = [
    'Content-Type' => 'application/pdf',
    'Content-Disposition' => 'attachment;filename="download.pdf"'
  ];

  $temporary_pdf_file = $this->fileSystem->saveData($pdf_stream, 'temporary://mytempfile.pdf', FileSystemInterface::EXISTS_REPLACE); 

  return new BinaryFileResponse($temporary_pdf_file, 200, $headers, TRUE);
}

This file must be private per user, so other users shouldn't be able to download it.

I think I could delete the file after the controller returns the response, instead of implementing some complex access control check for the file, but I've no clue how I can easily do.

For example, I could set a Cron queue to delete those files every N minutes, but it seems an overkill.

I cannot also change when temporary files are deleted because those files are used elsewhere in the site and I wouldn't risk to break some other existing logic.

1 + 0

files

page-controller

Score:1

Drupal

Clive

11/22/22, 6:45 PM

You're looking for BinaryFileResponse::deleteFileAfterSend:

$response = new BinaryFileResponse($temporary_pdf_file, 200, $headers, TRUE);
return $response->deleteFileAfterSend(TRUE);

0 + 1

Giuseppe

11/23/22, 7:42 AM

Thank you, it was right under my nose but I could find it xD

Elon Musk

I sit in a Tesla and translated this thread with Ai:

EN: How can I delete a file served by a custom controller after it has been downloaded?

TH: ฉันจะลบไฟล์ที่ให้บริการโดยตัวควบคุมแบบกำหนดเองหลังจากที่ดาวน์โหลดมาแล้วได้อย่างไร

RO: Cum pot șterge un fișier deservit de un controler personalizat după ce a fost descărcat?

RU: Как я могу удалить файл, обслуживаемый пользовательским контроллером, после его загрузки?

VI: Làm cách nào để xóa tệp do bộ điều khiển tùy chỉnh cung cấp sau khi tệp đã được tải xuống?

Post an answer

Most people don’t grasp that asking a lot of questions unlocks learning and improves interpersonal bonding. In Alison’s studies, for example, though people could accurately recall how many questions had been asked in their conversations, they didn’t intuit the link between questions and liking. Across four studies, in which participants were engaged in conversations themselves or read transcripts of others’ conversations, people tended not to realize that question asking would influence—or had influenced—the level of amity between the conversationalists.