When there is a Drupal.org issue with patches on it already what is the best (most polite, easiest, most technically sound) way to make a GitLab fork?

mlncn

12/27/22, 6:27 PM

Scenario: There is an issue with a patch. Perhaps the patch edits a module's composer.json for Drupal 9 compatibility such that the recommended way to use the patch is as an issue fork.

What is the best way (most polite, easiest, most technically sound) way to make a GitLab issue fork with the latest patch included? Or maybe more specifically i'm wondering:

There's no automated "Create issue fork from patch" button somewhere that i'm missing?
Applying the latest patch to an issue fork should be announced as identical to the latest patch in the issue? Or is it evident enough?
Are there plans or an effort to automate patch-to-fork (forks can already be used as patches)?

Thanks!

1 + 0

version-control

community-official-site

Score:1

Drupal

apaderno

12/28/22, 10:11 AM

The user interface for an issue branch doesn't show, to users who can push code in it, a button to automatically apply a patch to the issue branch.

Supposing the issue branch doesn't exist, you can create it and apply the branch following these steps.

Create the issue branch by clicking on the Create issue fork button that appears on the issue after the issue summary
Follow the instructions given on Creating issue forks and merge requests » Cloning and committing code to an issue fork to set up the local repository for the issue branch
Use curl [patch-link] | git apply - or wget -q -O - [patch-link] | git apply - to apply the patch to the issue branch local repository
Push the changes in the issue branch

[patch-link], for patches attached to issues on drupal.org is, for example, https://www.drupal.org/files/issues/2021-08-28/2557319-17.patch, not https://www.drupal.org/files/2557319-17.patch as Applying a patch in a feature branch seems to imply.

Posting a comment that explains you created the issue branch and applied the patch is fine. Users could find out the issue branch includes the patch, or assume you did that; commenting about what you did isn't wrong.

Looking at the issues for the project containing the drupal.org custom code, the ones for Gitlab integration, I don't see any issue for adding a button to apply a patch directly from the issue branch user interface, probably because it requires changing the Gitlab code, or it's not considered a necessary feature.

0 + 0

Elon Musk

I sit in a Tesla and translated this thread with Ai:

EN: When there is a Drupal.org issue with patches on it already what is the best (most polite, easiest, most technically sound) way to make a GitLab fork?

TH: เมื่อ Drupal.org มีปัญหาเกี่ยวกับโปรแกรมแก้ไขแล้ว วิธีใดที่ดีที่สุด (สุภาพที่สุด ง่ายที่สุด ฟังดูเป็นเทคนิคที่สุด) ในการสร้าง GitLab fork

RO: Când există deja o problemă Drupal.org cu patch-uri pe el, care este cea mai bună (cel mai politicos, mai ușor, cel mai sunet din punct de vedere tehnic) mod de a face o furcă GitLab?

RU: Когда на Drupal.org уже есть проблема с исправлениями, как лучше всего (наиболее вежливо, проще и технически разумно) создать форк GitLab?

VI: Khi có vấn đề về Drupal.org với các bản vá trên đó, cách tốt nhất (lịch sự nhất, dễ dàng nhất, hợp lý nhất về mặt kỹ thuật) để tạo một ngã ba GitLab là gì?

Post an answer

Most people don’t grasp that asking a lot of questions unlocks learning and improves interpersonal bonding. In Alison’s studies, for example, though people could accurately recall how many questions had been asked in their conversations, they didn’t intuit the link between questions and liking. Across four studies, in which participants were engaged in conversations themselves or read transcripts of others’ conversations, people tended not to realize that question asking would influence—or had influenced—the level of amity between the conversationalists.