addViolation() is deprecated: how to replace it?

Baud

5/6/23, 9:46 AM

How to adapt the following code to avoid the deprecation of addViolation() according to https://www.drupal.org/node/3238432 ?

class MyValidator extends ConstraintValidator {

  public function validate($items, Constraint $constraint) {
    if (!$this->isValid($items)) {
      $this->context->addViolation($constraint->message); // How to adapt this line?
    }
  }
}

128

0 + 0

symfony-services

4uk4

5/6/23, 1:27 PM

I think the deprecation message is a false alarm. In contrast to the methods mentioned in the change record addViolation() is not marked as internal in Symfony 6 and if Drupal removes this method they will replace it with Symfony code.

Baud

5/6/23, 1:37 PM

thank you. Is this means that the deprecation code has been falsely added to the addViolation() method... Some kind of Core bug I would say?

4uk4

5/6/23, 2:03 PM

It's not falsely added, it's clear they want to remove this implementation of the method. This doesn't change the usage of the method, though, it is used the same way in Symfony.

Score:2

Drupal

apaderno

5/6/23, 11:23 PM

The code shown in the question doesn't need to be changed: Once Start using the class Symfony\Component\Validator\ValidatorBuilder instead of copied classes is fixed, $this->context won't contain anymore an instance of \Drupal\Core\TypedData\Validation\ExecutionContext but \Symfony\Component\Validator\Context\ExecutionContext.
As the documentation says, classes that extend ConstraintValidator should just assume that $this->context is an object implementing ExecutionContextInterface, not which class is actually used. With that assumption, the changes introduced by that issue won't influence contrain validator classes (except for the fact the deprecation message won't be anymore triggered).

0 + 0