Score:0

Server

conditional statements should not include jinja2 with dictionary list

Nifle

2/7/24, 4:54 PM

How do I get rid of this warning?
The task works as expected but I would like to do it correctly

I have tried to fish out the value for ansible_facts.services["{{ component }}.service"].state and save it in a variable without any success.

---

- hosts: localhost
  become: no
  gather_facts: true

  vars:
    component: firewalld

  tasks:

  - name: Populate service facts
    ansible.builtin.service_facts:

  - name: "servicestatus"
    debug:
      msg: "{{ component }} is running, do stuff"
    when: 'ansible_facts.services["{{ component }}.service"].state == "running"'

  - name: "wokka"
    debug:
      var: ansible_facts.services["{{component}}.service"].state

$ ansible-playbook example.yml

PLAY [localhost] **************************************************************************************************

TASK [Gathering Facts] ********************************************************************************************
ok: [localhost]

TASK [Populate service facts] *************************************************************************************
ok: [localhost]

TASK [servicestatus] **********************************************************************************************
[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found:
ansible_facts.services["{{ component }}.service"].state == "running"
ok: [localhost] => {
    "msg": "firewalld is running, do stuff"
}

TASK [wokka] ******************************************************************************************************
ok: [localhost] => {
    "ansible_facts.services[\"firewalld.service\"].state": "running"
}

PLAY RECAP ********************************************************************************************************
localhost                  : ok=4    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

652

2 + 0

ansible

jinja2

Score:2

Server

larsks

2/7/24, 6:16 PM

You never nest Jinja {{...}} markers. If you're inside a template context (which you are, implicitly, in a when statement), you just refer to variables by name. So instead of:

  - name: "servicestatus"
    debug:
      msg: "{{ component }} is running, do stuff"
    when: 'ansible_facts.services["{{ component }}.service"].state == "running"'

  - name: "wokka"
    debug:
      var: ansible_facts.services["{{component}}.service"].state

You want:

  - name: "servicestatus"
    debug:
      msg: "{{ component }} is running, do stuff"
    when: 'ansible_facts.services[component ~ ".service"].state == "running"'

  - name: "wokka"
    debug:
      var: ansible_facts.services[component ~ ".service"].state

Here we're using the ~ string concatenation operator. You could accomplish the same thing with string formatting syntax, like this:

  - name: "servicestatus"
    debug:
      msg: "{{ component }} is running, do stuff"
    when: 'ansible_facts.services["%s.service" % (component)].state == "running"'

+ 1

Nifle

2/7/24, 8:07 PM

Wonderful. Works like a charm. Seems i really should read up on jinja, I never new either of those ways to format/concat strings

Score:1

Server

Vladimir Botka

2/8/24, 9:54 AM

Get rid of the extension .service. For example, put the below declarations into the group_vars

shell> cat group_vars/all/my_services.yml 
my_keys: "{{ ansible_facts.services.keys()|
             map('reverse')|
             map('split', '.', 1)|
             map('last')|
             map('reverse') }}"
my_services: "{{ dict(my_keys|zip(ansible_facts.services.values())) }}"

gives

  my_services:
    ModemManager:
      name: ModemManager.service
      source: systemd
      state: inactive
      status: disabled
    NetworkManager:
      name: NetworkManager.service
      source: systemd
      state: stopped
      status: masked
    ...

Given the variable

  component: ssh

Both getting the facts and testing the state are simpler. The code is cleaner.

    - debug:
        var: my_services[component]

gives

  my_services[component]:
    name: ssh.service
    source: systemd
    state: running
    status: enabled

and

    - debug:
        msg: "{{ component }} is running"
      when: my_services[component].state == 'running'

gives

  msg: ssh is running

^{Example of a complete playbook for testing
shell> cat pb.yml
- hosts: localhost

vars:

component: ssh

tasks:

- ansible.builtin.service_facts:
- debug:
var: my_services
when: debug|d(false)|bool

- debug:
var: my_services[component]

- debug:
msg: "{{ component }} is running"
when: my_services[component].state == 'running'}

+ 0

Elon Musk

I sit in a Tesla and translated this thread with Ai:

EN: conditional statements should not include jinja2 with dictionary list

Post an answer

Most people don’t grasp that asking a lot of questions unlocks learning and improves interpersonal bonding. In Alison’s studies, for example, though people could accurately recall how many questions had been asked in their conversations, they didn’t intuit the link between questions and liking. Across four studies, in which participants were engaged in conversations themselves or read transcripts of others’ conversations, people tended not to realize that question asking would influence—or had influenced—the level of amity between the conversationalists.