You were asked to configure a trust from two way to ONE way so that a that a share in PROD (and any other resource in PROD) is only accessible to PROD and NOT dev. Now dev users are unable to access the share in PROD.
This is the expected behavior.
Removing the two way trust is the correct thing to do. It should never have been created.
If you want a share (or any other resource) to be available to the dev domain, the resource (share) needs to be in a location independent from the PROD domain that should not be accessible from the dev domain.
Additional information:
The Everyone security principal was changed in 2003 to not be "Everyone". It is functionally identical to the Authenticated Users security principal. Previously Everyone functioned similar to a Guest account functionality, which is usually disabled. This means that the Everyone principal does not include Anonymous.
https://learn.microsoft.com/en-us/windows/security/threat-protection/security-policy-settings/network-access-let-everyone-permissions-apply-to-anonymous-users
In summary, Windows requires that users must authenticate to access a resource such as a share. There is no anonymous or guest access, and Everyone means only users that have authenticated from trusted domains.
The relationship between the resource in the PROD domain and the principals that you want to grant access has been specifically configured to disallow all access to all users that are from untrusted domains, to all resources, including shares.